On Mon, Nov 14, 2011 at 9:23 AM, Thierry Reding thierry.reding@avionic-design.de wrote:
- Simon Glass wrote:
Hi Stephen,
On Mon, Nov 14, 2011 at 9:09 AM, Stephen Warren swarren@nvidia.com wrote:
Thierry Reding wrote at Monday, November 14, 2011 6:22 AM:
If a board configuration file redefines CONFIG_SYS_TEXT_BASE, the U-Boot build system will usually define it explicitly on the compiler command- line, which will cause the define in tegra2-common.h to emit a redefinition warning.
To allow boards to redefine CONFIG_SYS_TEXT_BASE, tegra2-common.h now only defines CONFIG_SYS_TEXT_BASE when it isn't already defined by the board configuration or the command-line respectively.
Instead of doing this, wouldn't it make sense to just switch all Tegra boards to TEXT_BASE=00108000 to match NVIDIA's flashing tool's assumptions? That way, no board would need to override TEXT_BASE at all.
These assumptions are true for all boards in the standard flashing tool builds; it's just that non-standard builds exist for some boards (those that happened to be upstreamed to U-Boot first) that allow use of 00e08000 instead.
Tom, Simon, what are your thoughts here?
I was going to say the same thing.
Okay, I can integrate that into the second version. Or would you prefer a separate patch?
Yes a separate patch would be better, please.
Thanks, Simon
Thierry