Marek Vasut wrote at Friday, November 11, 2011 7:51 PM:
This command boots Linux zImage from where the zImage is loaded to. Passing initrd and fdt is supported.
Marek, this looks pretty neat. A few general questions though:
1) I believe the zImage format is ARCH-specific. I'm not sure that on non-ARM ARCHs, you just start executing at the start of the zImage. Should this function be somehow disabled on non-ARM until something explicit is done about that?
2) Should bootz_start() validate it was passed a valid zImage, by checking the magic value in the header?
3) boot_get_ramdisk() only accepts uImage (legacy or FIT). Can/should it be enhanced to accept raw ramdisk images?
4) Is it safe to assume that do_bootm_linux() only cares about images->ep and nothing else for the kernel? I know it's coded that way right now, but I wonder if someone might refactor bootm and forget about bootz and change this assumption. I guess this is OK though...
I don't have any other specific comments on the code.
You may want to CC everyone else involved in the IH_TYPE_KERNEL_NOLOAD discussion - I imagine they'll all be interested in this too.
-- nvpublic