Re: [U-Boot] [UBOOT PATCH v2 2/2] arm64: zynqmp: mmc: Added Kconfig support for CONFIG_ZYNQ_SDHCI1

On 28.2.2018 08:42, Jaehoon Chung wrote:

Hi,

On 02/28/2018 03:28 PM, Vipul Kumar wrote:

...

This patch added Kconfig support for CONFIG_ZYNQ_SDHCI1 and enabled it in defconfig.

I think that CONFIG_ZYNQ_SDHCI1 is meaningful when CONFIG_ZYNQ_SDHCI0 is enabled. It's used in zynqmp.c and spl.c ..like below..

#if defined(CONFIG_ZYNQ_SDHCI0) && defined(CONFIG_ZYNQ_SDHCI1) .... #endif

If CONFIG_ZYNQ_SDHCI0 isn't enabled, doesn't it need to set CONFIG_ZYNQ_SDHCI1 in defconfigs.

If i missed something, let me know, plz.

you are right. Dependency should be

config ZYNQ_SDHCI1 ... depends on ZYNQ_SDHCI0

Do you agree?

Thanks, Michal