Hi Alexey,
2015-01-03 22:20 GMT+09:00 Alexey Brodkin Alexey.Brodkin@synopsys.com:
Now when we may select commands via menuconfig let's adjust default settings with "config_cmd_default.h".
As the next step we may get rid of "config_cmd_default.h" inclusion in "include/configs/*.h" and "config_cmd_default.h" itself.
Thanks for working on this, but I think this patch changes the behavior.
Some boards include <config_cmd_default.h> and then undefine unnecessary commands.
For example, include/configs/snapper9260.h
#include <config_cmd_default.h> #undef CONFIG_CMD_BDI #undef CONFIG_CMD_FPGA #undef CONFIG_CMD_IMI #undef CONFIG_CMD_IMLS #undef CONFIG_CMD_LOADS #undef CONFIG_CMD_SOURCE
If you set the default value to "y" in Kconfig, it cannot be undef'ed by C-headers.
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com Cc: Tom Rini trini@ti.com
common/Kconfig | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
diff --git a/common/Kconfig b/common/Kconfig index fd84fa0..cbc4f5b 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -24,11 +24,13 @@ menu "Info commands"
config CMD_BDI bool "bdinfo"
default y help Print board info
This change enables CMD_BDI for all the boards.
Please notice the following boards do not want to compile this command.
./include/configs/dbau1x00.h:#undef CONFIG_CMD_BDI ./include/configs/pb1x00.h:#undef CONFIG_CMD_BDI ./include/configs/at91sam9m10g45ek.h:#undef CONFIG_CMD_BDI ./include/configs/davinci_schmoogie.h:#undef CONFIG_CMD_BDI ./include/configs/meesc.h:#undef CONFIG_CMD_BDI ./include/configs/at91sam9263ek.h:#undef CONFIG_CMD_BDI ./include/configs/usb_a9263.h:#undef CONFIG_CMD_BDI ./include/configs/at91sam9rlek.h:#undef CONFIG_CMD_BDI ./include/configs/taurus.h:#undef CONFIG_CMD_BDI ./include/configs/davinci_sonata.h:#undef CONFIG_CMD_BDI ./include/configs/afeb9260.h:#undef CONFIG_CMD_BDI ./include/configs/at91sam9261ek.h:#undef CONFIG_CMD_BDI ./include/configs/snapper9260.h:#undef CONFIG_CMD_BDI ./include/configs/at91sam9260ek.h:#undef CONFIG_CMD_BDI ./include/configs/tny_a9260.h:#undef CONFIG_CMD_BDI ./include/configs/ethernut5.h:#undef CONFIG_CMD_BDI ./include/configs/davinci_dvevm.h:#undef CONFIG_CMD_BDI ./include/configs/davinci_dm355leopard.h:#undef CONFIG_CMD_BDI ./include/configs/davinci_sffsdr.h:#undef CONFIG_CMD_BDI ./include/configs/davinci_dm6467evm.h:#undef CONFIG_CMD_BDI ./include/configs/vct.h:#undef CONFIG_CMD_BDI ./include/configs/vl_ma2sc.h:#undef CONFIG_CMD_BDI ./include/configs/corvus.h:#undef CONFIG_CMD_BDI ./include/configs/sbc35_a9g20.h:#undef CONFIG_CMD_BDI ./include/configs/pm9261.h:#undef CONFIG_CMD_BDI ./include/configs/davinci_dm355evm.h:#undef CONFIG_CMD_BDI ./include/configs/pm9263.h:#undef CONFIG_CMD_BDI ./include/configs/davinci_dm365evm.h:#undef CONFIG_CMD_BDI ./include/configs/cpu9260.h:#undef CONFIG_CMD_BDI ./include/configs/jadecpu.h:#undef CONFIG_CMD_BDI
@@ -193,6 +204,7 @@ config CMD_USB
config CMD_FPGA bool "fpga"
default y help FPGA support.
Moreover, I doubt some of default commands in <config_cmd_default.h> (I have used only some of commands in <config_cmd_default.h>)
For example, it seems weird to enable CONFIG_CMD_FPGA by default.
I do not think most of boards have FPGA.