On 11/27/20 1:43 PM, Bin Meng wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Hi Padmarao,
On Fri, Nov 27, 2020 at 8:18 PM Padmarao Begari padmarao.begari@microchip.com wrote:
Add device tree for Microchip PolarFire SoC Icicle Kit.
snip
--- /dev/null +++ b/arch/riscv/dts/microchip-mpfs-icicle-kit.dts @@ -0,0 +1,421 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* Copyright (c) 2020 Microchip Technology Inc */
+/dts-v1/; +#include "dt-bindings/clock/microchip,pfsoc-clock.h"
+/* Clock frequency (in Hz) of the rtcclk */ +#define RTCCLK_FREQ 1000000
+/ {
#address-cells = <2>;#size-cells = <2>;model = "Microchip PolarFire-SoC";compatible = "microchip,polarfire-soc";Should this be: "microchip,polarfire-soc-icicle-kit"?
My preference for this would go to: "microchip,mpfs-icicle-kit". This is the name used to order the board and what is written on the box.
As a rule please use "mpfs" as identifier in place of "polarfire-soc", "pfsoc", "pse", "g5soc" or whatever other variation on the theme when not using the marketing name of the device.
Regards,
Cyril.