On Thu, Oct 27, 2022 at 04:18:39PM +0530, Sinthu Raja wrote:
From: Sinthu Raja sinthu.raja@ti.com
Update setup_board_eeprom_env() to choose the right board name for am68-sk.
Signed-off-by: Sinthu Raja sinthu.raja@ti.com
board/ti/j721s2/evm.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/board/ti/j721s2/evm.c b/board/ti/j721s2/evm.c index e09adc8ad3..e3c75b35b6 100644 --- a/board/ti/j721s2/evm.c +++ b/board/ti/j721s2/evm.c @@ -28,6 +28,8 @@
#define board_is_j721s2_som() board_ti_k3_is("J721S2X-PM1-SOM")
+#define board_is_am68_sk_som() board_ti_k3_is("AM68-SK-SOM")
DECLARE_GLOBAL_DATA_PTR;
int board_init(void) @@ -136,6 +138,8 @@ static void setup_board_eeprom_env(void)
if (board_is_j721s2_som()) name = "j721s2";
- else if (board_is_am68_sk_som())
name = "am68-sk";
What I'd like to see is moving the board_is_XXX defines moved down to by do_board_detect() and then a comment inside the start of that block to explain that all of this functionality is specific to the EVM family designs. This will hopefully make it clearer that when making a custom board that doesn't have this EEPROM all of this can be omitted and we don't loose the "mini" U-Boot concept for this SoC.