On Sat, 2014-03-22 at 07:46 +0100, Wolfgang Denk wrote:
Dear Ian Campbell,
In message 1395438866-1193-5-git-send-email-ijc@hellion.org.uk you wrote:
This has been stripped back for mainlining and supports only sun7i booting via FEL mode. These changes are not useful by themselves but are split out to make the patch sizes more manageable.
As well as the following signed-off-by the sunxi branch shows commits to these files authored by the following:
What does that mean? I cannot find these names in the SoB lines?
I explained the process by which I arrived at these lists in 0/9. It means that they appear as an author for a commit in the history in the u-boot-sunxi.git, but did not supply an S-o-b. However I am adding my own S-o-b under clause (b) of the DCO, which I believe applies here.
It's entirely possible that none of these peoples' contributions still remain in the files being upstreamed, but figuring that out for sure would be a large and manual task. As I explained in 0/9 I prefer to over-credit by mentioning people whose actual contributions no longer remain rather than fail to credit someone whose contribution does remain. Even if their code doesn't remain it could be argued that they contributed to the evolution of the code. I didn't really want to get into the whole question of whether any individual contribution was sufficient to deserve credit or substantive enough to endow a copyright claim etc.
(git blame does not help here BTW, it will just tell you the last person to touch a line, not whether that change was substantive from a copyright PoV etc)
Almo Nito Carl van Schaik FUKAUMI Naoki hehopmajieh j
And these are not actually names ... nor do we have the e-mail addresses...
I have email addresses from the commit authorship, which I should indeed have included here, I shall definitely do that for v3. Please let me know whether or not I should also spend hours trawling down the precise pedigree of each line of code.
Ian.