Dear Darius Augulis,
On 30 November 2010 17:17, Darius Augulis augulis.darius@gmail.com wrote:
Hi,
thank you for review. Please find my questions inline:
+static void dm9000_pre_init(void) +{
- SROM_BW_REG &= ~(0xf << 4);
u-boot don't allow it. Please use read/write function. And please access the register by C structure.
it's clear about read/write. But why C structure? We have all register definitions in header file.
It's old style.
What are advantages of C structure? Many boards use definitions and I like it. Why to change?
It's mandatory. Please see below link. (explained well) http://www.mail-archive.com/u-boot@lists.denx.de/msg11583.html
+#define CONFIG_CMDLINE_EDITING +#define CONFIG_BAUDRATE 115200 +#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } +#define CONFIG_BOOTCOMMAND "nand read 50100000 100000 300000; bootm 50100000"
If you load the uImage to 0x500fffc0 (0x50100000 - 0x40), then you can reduce the boot time (about 0.5 sec?).
why? please explain.
Please see this patch. http://git.denx.de/?p=u-boot.git;a=commitdiff;h=fca0cecff73db99d99ad094cca79...
If load address and image start address are same address, then memmove is unnecessary. Because of u-boot header, we should load the image to start address - 0x40 (size of u-boot header). This is not mandatory. I just gave you some tips
thanks, Darius
Thanks Minkyu Kang