Dear Wolfgang Denk,
Dear Reinhard Meyer,
In message4D01EA19.8070200@emk-elektronik.de you wrote:
Sorry for the noise, but...
just looked in the timer implementation for arm926ejs based boards, and found that there is just the at91, davinci, nomadik timer implementation fixed in actual u-boot. I want to cleanup this timers too, but there are kirkwood, mb86r0x, orion5x, spear, versatile archs which use a lastdec var, which is not in global_data.h defined. So the question is should we add a lastdec to global_data.h or is it Ok, if I use lastinc for cleaning up?
I would suggest to take tbu, tbl, lastinc out of the AT91FAMILY #ifdef to the generic part.
maybe "unify" last{inc,dec} into last_hw ? Because they are supposedly the last (hardware) decrementer/incrementer values from the previous call.
define 4 u32's in the generic part:
u32 timer_use1; u32 timer_use2; u32 timer_use3; u32 timer_use4;
NAK. Please let's agree on common names. Eventually we will even come up with a common implementation later (with just arch-specific "accessor" routines).
Replace "arch" by "SoC" here! ARM itself does not have a timer (in contrast to powerpc where tbu,tbl is part of the architecture) !
Then its a bad idea to take tbu,tbl out of the #ifdef AT91FAMILY part when all other ARM timer implementations do not use tbu.
Its simple to NAK attempts to come up with "common" names that are NOT misnomers on some implementations... tbu, tbl are certainly misnomers on all non AT91 timer implementations...
Reinhard