Am 07.07.2019 um 20:40 schrieb Frank Wunderlich:
any new opinions about last version? can it be merged to next u-boot version?
I remember having answered to v5, then you sent v6 and without further responses sent v7. I fail to read from the patches what actually changed between the versions. You have written a changelog in the cover letter, please do so for the different patches as well.
Further, you have not integrated by Reviewed-by tag to 1/2 I sent for v5...
I'll no go and manually diff v6 and v6, and then reply sigh...
But even then, keep in mind I'm not the one mergin this!
Regards, Simon
regards Frank
Gesendet: Samstag, 29. Juni 2019 um 11:36 Uhr Von: "Frank Wunderlich" frank-w@public-files.de An: "Simon Goldschmidt" simon.k.r.goldschmidt@gmail.com, u-boot@lists.denx.de Cc: "Frank Wunderlich" frank-w@public-files.de Betreff: [PATCH v7 0/2] add command env erase
sometimes it is needed to erase the non-volatile environment e.g. for boot-up with builtin-environment or after resizing env
this series add basic functionality for erasing environment from storage as a first storage-driver mmc is introduced, other needs to be added later
changes since v6:
- fix whitespace around errmsg
changes since v5:
- don't use the CMD_RET_ macros in erase_env
- remove mmc-checks (!mmc + mmc_getwp) and add init_mmc_for_env
changes since v4:
- rebased to 2019.07-rc4
- changed handling with CONFIG_ENV_OFFSET_REDUND (more similar to saveenv)
- quashed last 2 commits to get 2-parts patchset
Frank Wunderlich (2): env: register erase command env: mmc: add erase-function
cmd/Kconfig | 8 +++++++ cmd/nvedit.c | 20 +++++++++++++++++ env/env.c | 30 +++++++++++++++++++++++++ env/mmc.c | 51 +++++++++++++++++++++++++++++++++++++++++++ include/environment.h | 17 +++++++++++++++ 5 files changed, 126 insertions(+)
-- 2.17.1