Re: [U-Boot] [PATCH v4 6/6] arm, davinci: Add support for generating AIS images to the Makefile

Hi Mike, Thanks for your comments.

On Friday, December 2, 2011, Mike Frysinger vapier@gentoo.org wrote:

On Friday 02 December 2011 11:12:10 Christian Riesch wrote:

...

+$(obj)u-boot.ais: $(obj)spl/u-boot-spl.bin $(obj)u-boot.bin

•         $(obj)tools/mkimage -s -n /dev/null -T aisimage \
  

•         -e $(CONFIG_SPL_TEXT_BASE) -d $(obj)spl/u-boot-spl.bin \
  

•         $(obj)spl/u-boot-spl.ais
  

•         $(OBJCOPY) ${OBJCFLAGS} -I binary \
  

•         --pad-to=$(CONFIG_SPL_MAX_SIZE) -O binary \
  

•         $(obj)spl/u-boot-spl.ais $(obj)spl/u-boot-spl-pad.ais
  

•         cat $(obj)spl/u-boot-spl-pad.ais $(obj)u-boot.bin > \
  

•         $(obj)u-boot.ais
  

lack of indentation on wrapped lines makes it hard to see what's going on

I'll change that.

The chaos above contains three commands: 1) I run the SPL through mkimage to add an AIS header for booting from SPI. Since an empty config file (-n) is sufficient here I use /dev/null here. 2) I pad the result $(obj)spl/u-boot-spl.ais to $CONFIG_SPL_MAX_SIZE with $(OBJCOPY): The result is $(obj)spl/u-boot-spl-pad.ais 3) Then I add $(obj)u-boot.bin with cat, the result is $(obj)u-boot.ais

...

•         rm $(obj)spl/u-boot-spl.ais
  

•         rm $(obj)spl/u-boot-spl-pad.ais
  

   rm $(obj)spl/u-boot-spl{,-pad}.ais

Ok.

Regards, Christian

-mike