[U-Boot-Users] Re: [PATCH] Nios: WATCHDOG preparation

Dear Stephan,,

in message 0402161009090A.00467@pcj86 you wrote:

Dear Stephan,,

attached patch includes the WATCHDOG_RESET() macro at some more points in U-Boot so I can use it in my upcoming new Nios board support. Please, merge it with current CVS tree -- thanks.

I would like to ask you to modify your patch.

@@ -1174,7 +1175,11 @@ static void smc_write_phy_register (byte #ifndef CONFIG_SMC91111_EXT_PHY static void smc_wait_ms(unsigned int ms) {

• /* B E W A R N E D :

• * DON'T EXCEED YOUR WATCHDOG TIMOUT WITH ARGUMENT 'ms' */
  

• WATCHDOG_RESET (); udelay(ms*1000);
• WATCHDOG_RESET ();

This should never be necessary. The udelay() function itself is expected to trigger the waitchdog as necessary.

If this is not the case on NIOS, then please fix this first. It might make some more of your modifications redundand, too.

Best regards,

Wolfgang Denk