Hi Bin,
On Thu, 23 Mar 2023 at 11:55, Simon Glass sjg@chromium.org wrote:
Hi Bin,
On Tue, 21 Mar 2023 at 14:25, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Tue, Mar 21, 2023 at 2:40 AM Simon Glass sjg@chromium.org wrote:
Hi Bin,
On Mon, 20 Mar 2023 at 19:32, Bin Meng bmeng.cn@gmail.com wrote:
Hi Simon,
On Tue, Feb 21, 2023 at 3:49 AM Simon Glass sjg@chromium.org wrote:
If U-Boot is not the first-stage bootloader we should not init the keyboard, since it has already been done. Check for this.
But re-init does no harm, right?
Actually it causes the keyboard to fail on Brya (Felwinter), a Chromebook. It could be due to it having a numeric keypad.
I assume Linux kernel will do the keyboard re-init no matter what bootloader does. So does Linux kernel fail to re-init the keyboard? If no, I guess we could improve the U-Boot keyboard driver somehow?
I found another way, to flush the buffer first.
Hmm no that does not always work, depending on what has happened before in coreboot.
Also it doesn't look like Linux always resets. Please see here:
https://github.com/torvalds/linux/blob/master/drivers/input/serio/i8042.c#L5...
Regards, Simon