On Wednesday 27 November 2013 05:42 AM, Vaibhav Bedia wrote:
On Mon, Nov 25, 2013 at 12:13 AM, Lokesh Vutla lokeshvutla@ti.com wrote:
On Friday 22 November 2013 02:16 AM, Vaibhav Bedia wrote:
On Thu, Nov 21, 2013 at 1:18 AM, Lokesh Vutla lokeshvutla@ti.com wrote:
AM4372 EPOS EVM has 1GB LPDDR2(Part no: MT42L256M32D2LG-25 WT:A) Adding LPDDR2 init sequence and register details for the same. Below is the brief description of LPDDR2 init sequence: -> Configure VTP -> Configure DDR IO settings -> Disable initialization and refreshes until EMIF registers are programmed. -> Program Timing registers -> Program PHY control and Temp alert and ZQ config registers. -> Enable initialization and refreshes and configure SDRAM CONFIG register -> Wait till initialization is complete and the configure MR registers.
This patch does too many things, some of which affects AM335x and needs to be split up. I lost track of what you were doing as i scrolled down :\
It does only two things. Update IO settings and emif configuration. I wanted to keep these things in a single patch so that if some functionality breaks down I can burn down to this patch.
That doesn't mean that you mix up everything in one humungous patch and try to force your way through.
OK, Ill separate out EMIF configuration and io settings and repost.
Thanks Lokesh
Signed-off-by: Lokesh Vutla lokeshvutla@ti.com
arch/arm/cpu/armv7/am33xx/ddr.c | 147 +++++++++++++++++++- arch/arm/cpu/armv7/am33xx/emif4.c | 25 +++- arch/arm/include/asm/arch-am33xx/clocks_am33xx.h | 3 + arch/arm/include/asm/arch-am33xx/cpu.h | 5 + arch/arm/include/asm/arch-am33xx/ddr_defs.h | 33 ++++- arch/arm/include/asm/arch-am33xx/hardware_am43xx.h | 1 + arch/arm/include/asm/emif.h | 12 ++ board/isee/igep0033/board.c | 10 +- board/phytec/pcm051/board.c | 12 +- board/siemens/dxr2/board.c | 10 +- board/siemens/pxm2/board.c | 10 +- board/siemens/rut/board.c | 10 +- board/ti/am335x/board.c | 40 +++++- board/ti/am43xx/board.c | 66 +++++++++ board/ti/ti814x/evm.c | 4 +- board/ti/ti816x/evm.c | 12 +- 16 files changed, 373 insertions(+), 27 deletions(-)
As the diffstat above shows, this patch affects a critical portion of AM335x, TI81xx and and at the same time adds in support for a new SoC. If that's not mixing up things i honestly don't know what is.
And if you have some discussions off-list you should at least attempt to capture the summary of what was agreed to do taken up as TODO for the benefit of others. If there's a agreed upon patch to improving the code that helps is overlooking some short term compromises.