Can somebody help me to understand and reproduce CI errors? I can run locally 'make check' which runs a bunch of local builds with binman and all of them are fine. It looks like some dependency is missing or addition 'git config --global --add safe.directory <path>/net/lwip/lwip-external' is required for the submodule directory.
https://source.denx.de/u-boot/custodians/u-boot-tpm/-/pipelines/17916
Building current source for 1 boards (0 threads, 24 jobs per thread) sandbox: + sandbox_spl +fatal: not a git repository (or any of the parent directories): .git +make[1]: *** [Makefile:1875: initsubmodules] Error 128 +make: *** [Makefile:177: sub-make] Error 2 0 0 1 /1 sandbox_spl Completed: 1 total built, 1 newly), duration 0:00:06, rate 0.17 Traceback (most recent call last): File "/builds/u-boot/custodians/u-boot-tpm/./tools/binman/binman", line 45, in <module> from binman import cmdline File "/builds/u-boot/custodians/u-boot-tpm/tools/binman/cmdline.py", line 11, in <module> from binman import state File "/builds/u-boot/custodians/u-boot-tpm/tools/binman/state.py", line 14, in <module> from dtoc import fdt File "/builds/u-boot/custodians/u-boot-tpm/tools/dtoc/fdt.py", line 14, in <module> from libfdt import QUIET_NOTFOUND ImportError: cannot import name 'QUIET_NOTFOUND' from 'libfdt' (unknown location)
On Tue, 26 Sept 2023 at 20:19, Tom Rini trini@konsulko.com wrote:
On Tue, Sep 26, 2023 at 08:16:35AM -0600, Simon Glass wrote:
Hi Tom,
On Tue, 26 Sept 2023 at 07:41, Tom Rini trini@konsulko.com wrote:
On Tue, Sep 26, 2023 at 05:37:25AM -0600, Simon Glass wrote:
Hi Maxim,
On Tue, 26 Sept 2023 at 03:43, Maxim Uvarov maxim.uvarov@linaro.org
wrote:
add external lwIP library as a git submodule. Use STABLE-2_2_0_RELEASE tag.
Signed-off-by: Maxim Uvarov maxim.uvarov@linaro.org
.gitmodules | 3 +++ net/lwip/lwip-external | 1 + 2 files changed, 4 insertions(+) create mode 100644 .gitmodules create mode 160000 net/lwip/lwip-external
Do you have comments on the rest of the series?
Not yet, but I should be able to review the rest in a few days. My main comments before were minor - return codes, tests, error checking.
OK, thanks. I don't know how exactly I want to proceed with the core of lwip itself, but that doesn't block reviewing and testing the rest of it as we'll move forward with it one way or another.
-- Tom