Re: [PATCH v1 09/10] pci: Add driver for Broadcom STB PCIe controller

Hi Nicolas,

On 4/28/20 15:59, Nicolas Saenz Julienne wrote:

...

• /*

• * For config space accesses on the RC, show the right class for
  

• * a PCIe-PCIe bridge (the default setting is to be EP mode).
  

• */
  

• tmp = readl(base + PCIE_RC_CFG_PRIV1_ID_VAL3);
• u32p_replace_bits(&tmp, 0x060400,

• 	  PCIE_RC_CFG_PRIV1_ID_VAL3_CLASS_CODE_MASK);
  

• writel(tmp, base + PCIE_RC_CFG_PRIV1_ID_VAL3);
• if (pcie->ssc) {

• ret = brcm_pcie_set_ssc(base);
  

This call should be like this:

ret = brcm_pcie_set_ssc(pcie);

It builds alright since base is a void pointer. But it obvioulsy causes issues further down the line.

Thanks for pointing this out, I have fixed it and re-tested again with SSC enabled and disabled.

-- Regards, Sylwester