Re: [U-Boot] [PATCH 7/7 V2] Sound: Add FDT support to CMD.

Hi Rajeshwari,

On Tue, Nov 27, 2012 at 10:10 PM, Rajeshwari Shinde rajeshwari.s@samsung.com wrote:

This patch adds FDT support to sound init in CMD.

Signed-off-by: Rajeshwari Shinde rajeshwari.s@samsung.com

Changes in V2: - Same function call for sound init in case of FDT or non FDT support. common/cmd_sound.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/common/cmd_sound.c b/common/cmd_sound.c index 459d1eb..e06b1db 100644 --- a/common/cmd_sound.c +++ b/common/cmd_sound.c @@ -33,7 +33,11 @@ static int do_init(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) { int ret;

•   ret = sound_init();
  

+#ifdef CONFIG_OF_CONTROL

•   ret = sound_init(gd->fdt_blob);
  

+#else

•   ret = sound_init(NULL);
  

+#endif

Can you remove this #ifdef and just always pass gd->fdt_blob?

    if (ret) {
            printf("Initialise Audio driver failed\n");
            return CMD_RET_FAILURE;

-- 1.7.4.4

Regards, Simon