Hi Stefano,
-----Original Message----- From: Stefano Babic [mailto:sbabic@denx.de] Sent: Wednesday, November 29, 2017 6:05 PM To: Peng Fan van.freenix@gmail.com; Stefano Babic sbabic@denx.de Cc: Peng Fan peng.fan@nxp.com; Fabio Estevam fabio.estevam@nxp.com; u-boot@lists.denx.de Subject: Re: [PATCH 01/23] imx: add i.MX8M into Kconfig
Hi Peng,
On 29/11/2017 06:49, Peng Fan wrote:
Hi Stefano,
On Tue, Nov 28, 2017 at 06:15:30PM +0100, Stefano Babic wrote:
Hi Peng,
On 28/11/2017 13:31, Peng Fan wrote:
Add i.MX8M into Kconfig, create a new folder mx8m dedicated for i.MX8M.
Signed-off-by: Peng Fan peng.fan@nxp.com
arch/arm/Kconfig | 8 ++++++++ arch/arm/Makefile | 4 ++-- arch/arm/mach-imx/mx8m/Kconfig | 10 ++++++++++ 3 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 arch/arm/mach-imx/mx8m/Kconfig
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 30e71b2569..e579986d14 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -588,6 +588,12 @@ config ARCH_MESON targeted at media players and tablet computers. We currently support the S905 (GXBaby) 64-bit SoC.
+config ARCH_MX8M
- bool "NXP i.MX8M platform"
- select ARM64
- select DM
- select SUPPORT_SPL
I think we should start from the beginning with support for multiple variants of the processor. I know there will be at least i.MX8 and i.MX8M, but I suppose that I am not well informed and many variants will come, exactly as we had with i.MX6.
So we need a hierarchy: first the SOC family, then the SOC variant: MX8 and MX8M (or whatever).
But in the patches, it is not clear because ARCH = SOC = M8M.
Which variants are already known ? As far as I can see, at least Quad, QuadMax and QuadPlus.
i.MX8M is different from Quad/QuadMax and etc. It is similar as i.MX6/7 , all is controlled by Cortex-A[x].
Ouch...
So I choose a new SoC family entry here. Just like we have MX7 and MX7ULP. MX8 will be used for Quad, QuadMax QuadX
Ok, this is also my expectation.
. MX8M here is used for i.MX8MQ and etc.
What do you think?
I have so less information and knowledge about the new NXP processors and I cannot better help, I trust your judge. But what can we share between M8M and M8 ? What about all stuff going into mx8m directories (cpu, closk, ..) ? Could they be reused for MX8 or do they remain an island ?
MX8M and MX8 has different architecture. To MX8, all clocks, power domains, pin configuration, and reset and etc are all controlled by SCU and different clock/power/xx architecture with MX8M.
So most code could not be reused.
Thanks, Peng.
Regards, Stefano
Thanks, Peng.
config ARCH_MX25 bool "NXP MX25" select CPU_ARM926EJS @@ -1157,6 +1163,8 @@ source "arch/arm/cpu/armv7/ls102xa/Kconfig"
source "arch/arm/mach-imx/mx2/Kconfig"
+source "arch/arm/mach-imx/mx8m/Kconfig"
source "arch/arm/mach-imx/mx7ulp/Kconfig"
source "arch/arm/mach-imx/mx7/Kconfig" diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 5f1caf8f86..4db0398dde 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -95,11 +95,11 @@ libs-y += arch/arm/cpu/ libs-y += arch/arm/lib/
ifeq ($(CONFIG_SPL_BUILD),y) -ifneq (,$(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_MX35)$(filter
$(SOC),
mx25 mx5 mx6 mx7 mx35)) +ifneq (,$(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_MX35)$(filter
$(SOC),
+mx25 mx5 mx6 mx7 mx35 mx8m)) libs-y += arch/arm/mach-imx/ endif else -ifneq (,$(filter $(SOC), mx25 mx27 mx5 mx6 mx7 mx7ulp mx31 mx35 mxs vf610)) +ifneq (,$(filter $(SOC), mx25 mx27 mx5 mx6 mx7 mx7ulp mx31 mx35 mxs +mx8m vf610)) libs-y += arch/arm/mach-imx/ endif endif diff --git a/arch/arm/mach-imx/mx8m/Kconfig b/arch/arm/mach-imx/mx8m/Kconfig new file mode 100644 index 0000000000..3a84c2f2b0 --- /dev/null +++ b/arch/arm/mach-imx/mx8m/Kconfig @@ -0,0 +1,10 @@ +if ARCH_MX8M
+config MX8M
- bool
- select ROM_UNIFIED_SECTIONS
+config SYS_SOC
- default "mx8m"
+endif
Best regards, Stefano
--
============================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
============================================================
--
========= DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de ============================================================ =========