On 20/01/24 22:11, Tom Rini wrote:
On Mon, Jan 15, 2024 at 01:42:51PM +0530, Siddharth Vadapalli wrote:
Hello Tom,
On 12/01/24 18:56, Tom Rini wrote:
...
The list of conditionals in common/spl/spl.c::board_init_r() should be updated and probably use SPL_NET as the option to check for.
Thank you for reviewing the patch and pointing this out. I wasn't aware of it. I assume that you are referring to the following change:
if (IS_ENABLED(CONFIG_SPL_OS_BOOT) || CONFIG_IS_ENABLED(HANDOFF) ||
IS_ENABLED(CONFIG_SPL_ATF))
IS_ENABLED(CONFIG_SPL_ATF) || IS_ENABLED(CONFIG_SPL_NET)) dram_init_banksize();I shall replace the current patch with the above change in the v2 series. Since this is in the common section, is there a generic reason I could provide in the commit message rather than the existing commit message which seems to be board specific? Also, I hope that the above change will not cause regressions for other non-TI devices. Please let me know.
Yes, that's the area, and just note that networking also requires the DDR to be initialized.
Thank you for confirming and providing your suggestion for the contents of the commit message.