20 May
2017
20 May
'17
4:29 a.m.
On 16 May 2017 at 21:44, Kever Yang kever.yang@rock-chips.com wrote:
In rk3328, some function pin may have more than one choice, and muxed with more than one IO, for example, the UART2 controller IO, TX and RX, have 3 choice(setting in com_iomux):
- M0 which mux with GPIO1A0/GPIO1A1
- M1 which mux with GPIO2A0/GPIO2A1
- usb2phy which mux with USB2.0 DP/DM pin.
We should not decide which group to use in pinctrl driver, for it may be different in different board, it should goes to board file, and the pinctrl file should setting correct iomux depends on the com_iomux value.
Signed-off-by: Kever Yang kever.yang@rock-chips.com
arch/arm/include/asm/arch-rockchip/grf_rk3328.h | 30 ++++++++-------- drivers/pinctrl/rockchip/pinctrl_rk3328.c | 47 +++++++++++++++---------- 2 files changed, 43 insertions(+), 34 deletions(-)
Acked-by: Simon Glass sjg@chromium.org