On Wed, May 12, 2010 at 3:02 PM, Detlev Zundel dzu@denx.de wrote:
Hi Michael,
diff --git a/board/barco/barco.c b/board/barco/barco.c index c5fe8c4..2d01f1b 100644 --- a/board/barco/barco.c +++ b/board/barco/barco.c @@ -348,12 +348,3 @@ int serial_tstc (void) { return 0; }
-unsigned long post_word_load (void) -{
- return 0l;
-} -void post_word_store (unsigned long val) -{
- return;
-}
This never worked :) The config file has no trace of any POST, so the change you do is pretty useless:
These changes are necessary for CONFIG_LOGBUFFER which barco board defines that in turn requires the post_word_load and post_word_store support.
Hm. It amazes me that CONFIG_LOGBUFFER needs a CONFIG_SYS_POST_WORD_ADDR - I simply did not realize this.
Ah, I see now that post.h produces these values when CONFIG_POST _or_ CONFIG_LOGBUFFER is defined. I guess this works, but it is non-obvious that we need post.h if no POST is used. But still this is no reason to NAK the patch.
Actually we do not need to include post.h if post is not used. Only cmd_log.c includes it. In this respect patch did not change anything.
Regards, Michael