10 Jul
2012
10 Jul
'12
8:36 p.m.
On Tue, Jul 10, 2012 at 1:35 PM, Timur Tabi timur@freescale.com wrote:
Joe Hershberger wrote:
diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c index bb57e4d..268d884 100644 --- a/drivers/net/sh_eth.c +++ b/drivers/net/sh_eth.c @@ -415,7 +415,11 @@ static int sh_eth_config(struct sh_eth_dev *eth, bd_t *bd) goto err_phy_cfg; } phy = port_info->phydev;
phy_startup(phy);
ret = phy_startup(phy);if (ret) {printf(SHETHER_NAME ": phy startup failure\n");Why is this string different from the others? Consistency?
Yes, it looks like the other messages in sh_eth_config().
Same here, at least the core message "Could not initialize PHY"
I am saying that, just in a different way. "phy startup failure" means the same as "Could not initialize PHY", but the wording matches the rest of the function.
OK.
-Joe