27 Mar
2012
27 Mar
'12
6:31 a.m.
Dear Tim Kientzle,
please do not top post / full quote. Especially not when submitting patches.
In message 2A2CB860-6BB6-46C5-B508-F7F97B1EB930@freebsd.org you wrote:
Hello, Anatolij,
Thank you for your response. Modified patch below:
On Mar 26, 2012, at 4:06 AM, Anatolij Gustschin wrote:
Hi Tim,
Thanks for the patch. Please see some comments below.
On Tue, 21 Feb 2012 22:34:35 -0800 Tim Kientzle kientzle@freebsd.org wrote:
The one-line patch below fixes device enumeration through the
...
All this would become the commit message - this doesn't work. Any such comments belong to the comment section, i. e. below the "---" line which would bepresentif you generated your patches using "git format- patch".
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
If there was anything that depressed him more than his own cynicism,
it was that quite often it still wasn't as cynical as real life.
- Terry Pratchett, _Guards! Guards!_