Hi Sergey,
On Monday 06 August 2007, ksi@koi8.net wrote:
Here it is.
Several changes from the original version:
- Got rid of types.h
- CPU directory is davinci now
- Saved something like 80 bytes in lowlevel_init.S
- Large Page NAND works now
- Removed a couple of #if 0
- MACH_TYPEs are in davinci.c now. This is wrong but nobody wants to update that mach-types.h header so there is no choice
- No default MAC address, having one is wrong
- A couple of harmless GCC warnings fixed
- Split in 5 text parts, no compressed patch any more
- Some other cosmetic fixes, spelling errors etc.
- Diff against the latest git tree as of right now
I do really hope it won't be sitting for another 3+ months and then declared made against an old tree... But I'm pretty sure it is how it's going to be, no illusions here :(
Hopefully you will be proven wrong here. Thanks for all the rework.
Seems that we now have two versions of the DaVinci patches. I suggest to use your patches for inclusion instead of Dirk's, because you are the original author. Dirk is welcome to send some review comments and/or Acked-by/Signed-off-by lines of course.
Here one comments from myself (I have to admit that the inline patches make the review a lot easier for me, since I'm sometimes just to lazy do it with attached compressed patches ;)):
I noticed that you have one board directory "board/davinci". And from my understanding (I'm no DaVinci expert at all) a lot of CPU (SoC) code is included in this board directory. Stuff like nand-driver or lowlevel_init seem quite cpu-specific. Please correct me if I'm wrong here. But if my finding is correct, I would like to seem some of this cpu-specific stuff moved into the cpu directory and perhaps rename the board directory into something not that generic as "board/davinci". We usually name the board directory according to the name of the board itself. You are supporting 3 different boards in this board directory right now. This makes it difficult to pick a name for such a board directory. But when more and more DaVince port will emerge, it will not be possible anymore to support them all in one board directory. It should be one board directory per board. Only *very* similar board should share a board directory.
So I suggest to create 3 separate board directories and try to move the generic, cpu-specific stuff in the cpu directory.
What do you think? Does this make sense?
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================