Re: [U-Boot] [PATCH 02/14] ARM: AM43xx: Adapt to ti_armv7_common.h config file

On Mon, Nov 4, 2013 at 11:20 PM, Lokesh Vutla lokeshvutla@ti.com wrote:

Use ti_armv7_common.h config file to inclde the common configs.

[...]

+/* Clock Defines */ +#define V_OSCK 24000000 /* Clock output from T2 */ +#define V_SCLK (V_OSCK)

I know this is slightly unrelated but i don't think hardcoding the osc freq is a good idea. We should be reading the PRCM register to detect the sysboot settings and then use that similar to the kernel. Follow up patch?

-/* Unsupported features */ -#undef CONFIG_USE_IRQ +/* NS16550 Configuration */ +#define CONFIG_SYS_NS16550_COM1 0x44e09000 /* Base EVM has UART0 */

I think the comment on base EVM is not applicable here ;)

Regards, Vaibhav