Re: [PATCH v2 2/2] of: addr: Remove call to dev_count_cells() in of_get_address()

Hi Simon,

On Sat, May 1, 2021 at 2:14 AM Simon Glass sjg@chromium.org wrote:

On Fri, 30 Apr 2021 at 07:17, Bin Meng bmeng.cn@gmail.com wrote:

...

In of_get_address(), there is:

dev_count_cells(dev, &na, &ns);

followed by:

bus->count_cells(dev, &na, &ns);

but no codes in between use na/ns, hence the first call is useless. By dropping the first call, dev_count_cells() is now useless too.

Signed-off-by: Bin Meng bmeng.cn@gmail.com

---

Changes in v2:

• new patch: of: addr: Remove call to dev_count_cells() in of_get_address()

drivers/core/of_addr.c | 6 ------ 1 file changed, 6 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

I wonder why this is now different from linux?

With this patch, the code flow is the same as Linux.

Regards, Bin

Applied to u-boot-dm, thanks!