Re: [U-Boot] [PATCH 03/41] Convert CONFIG_CMD_MFSL to Kconfig

On Sat, Jul 22, 2017 at 7:11 AM, Simon Glass sjg@chromium.org wrote:

This converts the following to Kconfig: CONFIG_CMD_MFSL

Signed-off-by: Simon Glass sjg@chromium.org

README | 1 - cmd/Kconfig | 7 +++++++ configs/microblaze-generic_defconfig | 1 + include/config_cmd_all.h | 1 - include/configs/microblaze-generic.h | 1 - scripts/config_whitelist.txt | 1 - 6 files changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Bin Meng bmeng.cn@gmail.com

Please check nits below.

diff --git a/README b/README index 023409b14c..aea19a257f 100644 --- a/README +++ b/README @@ -838,7 +838,6 @@ The following options need to be configured: CONFIG_CMD_TIMER * access to the system tick timer CONFIG_CMD_USB * USB support CONFIG_CMD_CDP * Cisco Discover Protocol support

•           CONFIG_CMD_MFSL         * Microblaze FSL support
            CONFIG_CMD_XIMG           Load part of Multi Image
            CONFIG_CMD_UUID         * Generate random UUID or GUID string
  
  

diff --git a/cmd/Kconfig b/cmd/Kconfig index c80ac364ea..a0155b9735 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -747,6 +747,13 @@ config CMD_SATA Attachment, where AT refers to an IBM AT (Advanced Technology) computer released in 1984.

+config CMD_MFSL

nits: should we add Kconfig options by following alphabetical order here?

•   bool "frd/fwr/rspr - Access special-purpose registers and SPL"
  

•   depends on MICROBLAZE
  

•   help
  

•     Provides access to Microblaze special purpose register amd FSL,
  

•     whatever that is.
  

endmenu

[snip]

Regards, Bin