Clean fpga_get_op() error handling by moving checking/print to do_fpga.
Signed-off-by: Michal Simek michal.simek@xilinx.com ---
cmd/fpga.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cmd/fpga.c b/cmd/fpga.c index 791fe5cb7718..abe683720285 100644 --- a/cmd/fpga.c +++ b/cmd/fpga.c @@ -74,6 +74,9 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) op = (int)fpga_get_op(argv[1]);
switch (op) { + case FPGA_NONE: + printf("Unknown fpga operation "%s"\n", argv[1]); + return CMD_RET_USAGE; #if defined(CONFIG_CMD_FPGA_LOADFS) case FPGA_LOADFS: if (argc < 9) @@ -360,9 +363,6 @@ static int fpga_get_op(char *opstr) op = FPGA_LOADS; #endif
- if (op == FPGA_NONE) - printf("Unknown fpga operation "%s"\n", opstr); - return op; }