On 01/25/2013 01:25:33 PM, Scott Wood wrote:
On 01/25/2013 12:50:59 PM, Tom Rini wrote:
On Fri, Jan 25, 2013 at 10:38:01AM -0600, Andy Fleming wrote:
The P2020DS build had grown too large, and video support isn't
enabled
in almost any other Freescale board. Disabling it allows us to keep building, and provides options for reenabling it later.
Signed-off-by: Andy Fleming afleming@freescale.com
Now we may start having dead code around, yes? Can you perhaps get away with making this be disable video or something else and add a P2020DS_video boards.cfg entry or similar? Thanks!
There are already 5 P2020DS targets, and there *should* be 8 (why is there no 36BIT version of DDR2, SDCARD, or SPIFLASH?).
I take that back -- there should be 16, as DDR2 seems to be orthogonal as well. So adding VIDEO on/off for all configs would bring it up to 32 if we fixed the rest.
I suppose you could just have one video config for compilation coverage, but it seems awkward, and what is it really testing? It's not the only board to enable BIOSEMU, ATI framebuffer, etc. You'd just be testing that it works with p2020ds, but for integration testing one config working might not say anything about another.
-Scott