On Mon, May 20, 2019 at 10:00 AM Adam Ford aford173@gmail.com wrote:
On Mon, May 20, 2019 at 7:38 AM Sekhar Nori nsekhar@ti.com wrote:
On 20/05/19 5:55 PM, Adam Ford wrote:
What about adding a memset function to the end of spl_board_init() so after arch_cpu_init() is called,and after preloader_consol_init() is called, we clear BSS? I ran some preliminary tests on da850evm and it didn't see to break anything. There are a few boards that appear to do things in this order.
This will work, but, looks like there is a desire to maintain some "standard" around this. Ie board_init_r() can assume BSS is available (see README -> Board Initialisation Flow:).
Doing BSS init in in spl_board_init() called from board_init_r() will violate that.
Based on your previous comment about board_init_f and your comment above, I read through the readme and I agree with your assessment that the current setup appears to already violate the startup flow.
Looking at board_f.c, there is a board_init_f which calls arch_cpu_init(), so I thought I might try to remove the call from spl_board_init. This didn't work. I then I attempted to rename spl_board_init to board_init_f to move these function calls earlier in the startup sequence. I also undefined SPL_BOARD_INIT from menuconfig, so the call to spl_board_init() wouldn't happen. Unfortunately, now the da850 doesn't start with that either. If you have any suggestions, I'm willing to try them.
I just submitted a patch which moves the initialization to board_init_f and clears BSS inside there. I was only able to test it on the da850evm. I am trying to get the da850 to boot from MMC, but it's not something I've done before, so it's taking a bit of time. It does appear to be recognizing whether or not the card initializes, but I am not sure why it's not run u-boot.img yet.
With card installed:
U-Boot SPL 2019.07-rc2-00579-gc17c82f15a-dirty (May 20 2019 - 14:48:11 -0500)
SPL: board_init_r()
Trying to boot from MMC1 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ###
Without card installed:
U-Boot SPL 2019.07-rc2-00579-gc17c82f15a-dirty (May 20 2019 - 14:48:11 -0500)
SPL: board_init_r()
Trying to boot from MMC1 Card did not respond to voltage select! spl: mmc init failed with error: -95 SPL: failed to boot from all boot devices ### ERROR ### Please RESET the board ###
I am at least making some progress.
adam
adam
Thanks, Sekhar