-----Original Message----- From: Heiko Schocher [mailto:hs@denx.de] Sent: Monday, February 15, 2010 1:40 PM To: Prafulla Wadaskar Cc: U-Boot user list; Wolfgang Denk; Scott Wood; Stefan Roese Subject: Re: [PATCH 3/4 v4] arm: add support for the suen3_p1a board from keymile
Hello Prafulla,
Prafulla Wadaskar wrote:
-----Original Message----- From: Heiko Schocher [mailto:hs@denx.de] Sent: Friday, February 12, 2010 1:36 PM To: U-Boot user list Cc: Wolfgang Denk; Prafulla Wadaskar; Scott Wood; Stefan Roese Subject: [PATCH 3/4 v4] arm: add support for the suen3_p1a board from keymile
This patch adds support for the Keymile suen3_p1a board which is based on the Marvell Kirkwood (88F6281) SoC. As this is a variant of the mgcoge2_arm_p1a board, this board also uses common code stored in board/keymile/km_arm/km_arm.c
I hope each board that you are supporting have registered
MACHIN_ID, if not pls do it and code it in C file.
No, this 4 boards are all the same, just different hardwarerevisions ...
Hi Heiko
If these boards are all same, why don't you add single board support? That will resolve all issues and even MACHINE_ID issue.
To me, any hardware revision is new board entity. If the hardware changes are very minimal those can be addressed by passing additional build arguments like "BOARDREV=V1" or handle them by reading h/w version from hardware itself, as I said earlier using EEPROM.
At least you can have first board patch clean and complete.
Regards.. Prafulla . .
bye, heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany