On 23 March 2015 at 10:40, Alexey Brodkin Alexey.Brodkin@synopsys.com wrote:
Hi Tom, Simon,
On Mon, 2015-03-16 at 11:03 +0300, Alexey Brodkin wrote:
Even though board_init_f_mem() is not used on x86 today there's no reason to not use it in the future.
Moreover board_init_f_mem() has nothing to do with any particular architecture so move it away from #else /* CONFIG_X86 */
Signed-off-by: Alexey Brodkin abrodkin@synopsys.com Cc: Simon Glass sjg@chromium.org Cc: Tom Rini trini@ti.com
Any comments on this one? This is a prerequisite for ARC updates so would be good to have it merged sometime soon.
I must have missed something as it did not seem to change anything for ARC.
This breaks building on x86 though, so we can't take this patch as is. E.g.:
x86: + crownbay +common/board_f.c: In function ‘board_init_f_mem’: +common/board_f.c:1092:5: error: lvalue required as left operand of assignment + gd = (struct global_data *)top; + ^
Regards, Simon