On Monday 14 May 2012 03:27:55 Kyungmin Park wrote:
On 5/14/12, Mike Frysinger wrote:
On Monday 14 May 2012 01:37:10 Kyungmin Park wrote:
On 5/14/12, Mike Frysinger wrote:
On Thursday 10 May 2012 01:23:40 Donghwa Lee wrote:
Makefile | 1 + include/libtizen.h | 30 + lib/tizen/Makefile | 46 + lib/tizen/tizen.c | 40 + lib/tizen/tizen_hd_logo.h | 5071 lib/tizen/tizen_hd_logo_data.h | 30 +
do you really need your own lib/tizen/ dir for a logo ? every one who doesn't build this still has to waste time going into lib/tizen/ to create an empty
object. at least make the addition of lib/tizen/ depend on CONFIG_TIZEN too.
It uses the same method as others does. e.g., libfdt
In Makefile LIBS += lib/libfdt/libfdt.o
In "lib/libfdt/Makefile" SOBJS =
COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o
COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt) COBJS-$(CONFIG_FIT) += $(COBJS-libfdt)
the difference is they have more than one CONFIG symbol going on, and their
code base is sizable, and many arches/boards utilize it. you're adding a single file with a single function with a single CONFIG knob for a single board.
Right, So we asked it first, which directory is proper. and suggested that the create the lib/tizen instead of others. since it's not platform, nor soc specific.
you can still do in the top level to avoid affecting other people: ifeq ($(CONFIG_TIZEN),y) LIBS += lib/tizen/libtizen.o endif -mike
Ok, I will update it later.
Thank you, Donghwa Lee.