"A. Sverdlin" alexander.sverdlin@siemens.com writes:
From: Alexander Sverdlin alexander.sverdlin@siemens.com
Commit 37cb626da25d0d ("mmc: sdhci: Add Support for ADMA2") introduced ADMA_DESC_LEN == 16 (64 bit case), but it was never used before commit 74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops").
"sizeof(struct sdhci_adma_desc)" (== 12 for 64bit case) was used instead.
Confusion probably originates from Linux commit 685e444bbaa0 ("mmc: sdhci: Add ADMA2 64-bit addressing support for V4 mode"), but the latter "V4 mode" was never ported to U-Boot.
Fixes: 74755c1fed1b0 ("mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops") Signed-off-by: Alexander Sverdlin alexander.sverdlin@siemens.com
include/sdhci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/sdhci.h b/include/sdhci.h index d73a725609be3..810ef56e4be66 100644 --- a/include/sdhci.h +++ b/include/sdhci.h @@ -300,7 +300,7 @@ struct sdhci_ops {
#define ADMA_MAX_LEN 65532 #ifdef CONFIG_DMA_ADDR_T_64BIT -#define ADMA_DESC_LEN 16 +#define ADMA_DESC_LEN 12 #else #define ADMA_DESC_LEN 8
#endif
2.44.0
on TI AM64 and AM62p platforms:
Tested-by: Jonathan Humphreys j-humphreys@ti.com