Hi,
On Sep 23, 2009, at 2:16 PM, Wolfgang Denk wrote:
Dear Olof Johansson,
In message 1D0F4997-6AF4-4BC3-94C3-0817551DBA84@lixom.net you wrote: ...
Use the omap gpio interface described in README.omap3
Seriously, this code is a 1:1 replica from the evm code. Obviously that code was good enough to merge.
Isn't this godd? It means that we learn from previous mistakes, and strive not to repeat them.
It's also a bit of "we're holding new contributors to higher standards than we hold ourselves", alternatively "we can merge crap, and when others use it as examples we'll make them clean it all up".
So, some of this is OK, I agree. That's why I did the whitespace cleanup yesterday. But I've reached my limit in this case.
Bottom line: I don't have more time to sink into this fairly trivial patch, I don't need to get it merged. I'll just carry it myself out of tree until I get bored enough to revisit it.
-Olof