El Fri, Jul 22, 2022 at 01:34:58PM +0200, Quentin Schulz deia:
From: Quentin Schulz quentin.schulz@theobroma-systems.com
This migrates the generation of u-boot-rockchip.bin from Makefile to binman completely. There is therefore no idbloader.img anymore as it is created on the fly by binman.
Thanks a lot.
I've tested this series and it worked for me and my Rock Pi 4B. That's a similar board, RK3399 too. Maybe it needs more refinements for other rockchip boards.
I haven't spent a lot of time testing yet, and I've tested it with two or three dozen patches on top of master, so not quite the real thing.
One thing that comes to mind is that master has CONFIG_ENV_IS_IN_MMC=y and I have it disabled and CONFIG_ENV_IS_NOWHERE=y. So maybe we should check in dtsi whether we need binman to call mkenvimage (and scripts/get_default_envs.sh or from what source?) and put the output at CONFIG_ENV_OFFSET=0x3F8000 for the SD image.
Or maybe we should just disable CONFIG_ENV_IS_IN_MMC in the board ? (I think it conflicts with trust settings anyway).
Or maybe just leave as it is and let env load non-fatally fail unless the user provides their own custom environment ?
Now that we have Quentin's patches maybe we can remove the Makefile warning about CONFIG_USE_SPL_FIT_GENERATOR and move the task that arch/arm/mach-rockchip/make_fit_atf.py is doing to binman. But I don't seem to find any dts using "split-elf" I even wonder, am I right to assume make_fit_atf.py is deprecated and split-elf prefered ? Because split-elf seems to be unused and make_fit_atf.py seems to be default ???