On Sun, Apr 03, 2016 at 09:18:09AM +0200, Beniamino Galvani wrote:
Support the Amlogic Meson GXBaby platform.
Signed-off-by: Beniamino Galvani b.galvani@gmail.com
[snip]
diff --git a/arch/arm/include/asm/arch-meson/gxbb.h b/arch/arm/include/asm/arch-meson/gxbb.h new file mode 100644 index 0000000..0eec270 --- /dev/null +++ b/arch/arm/include/asm/arch-meson/gxbb.h @@ -0,0 +1,10 @@ +/*
- (C) Copyright 2016 - Beniamino Galvani b.galvani@gmail.com
- SPDX-License-Identifier: GPL-2.0+
- */
+#ifndef __GXBB_H__ +#define __GXBB_H__
+#endif /* __GXBB_H__ */
Why do we need an empty header? Ah, I see later in the series...
diff --git a/arch/arm/mach-meson/board.c b/arch/arm/mach-meson/board.c new file mode 100644 index 0000000..346a2c2 --- /dev/null +++ b/arch/arm/mach-meson/board.c
[snip]
+int board_init(void) +{
- return 0;
+}
This really should go into the board/ board file
diff --git a/board/hardkernel/odroid-c2/README b/board/hardkernel/odroid-c2/README new file mode 100644 index 0000000..b900694 --- /dev/null +++ b/board/hardkernel/odroid-c2/README @@ -0,0 +1,34 @@ +* U-Boot for ODROID-C2: quick guide
+** Compile u-boot
+** Create the image
https://github.com/hardkernel/u-boot.git -b odroidc2-v2015.01 \$DIR--bl301 $DIR/fip/gxb/bl301.bin \--bl31 $DIR/fip/gxb/bl31.bin \--bl33 u-boot.bin \$DIR/fip.bin--input $DIR/boot_new.bin \--output $DIR/u-boot.img
Why can't we have these tools in mainline? Yes, the binaries (likely) need to live elsewhere, and we should perhaps give links on how to grab / build the particular supported blobs. See board/hisilicon/hikey/README for an example.
diff --git a/board/hardkernel/odroid-c2/odroid-c2.c b/board/hardkernel/odroid-c2/odroid-c2.c new file mode 100644 index 0000000..6a1485f --- /dev/null +++ b/board/hardkernel/odroid-c2/odroid-c2.c @@ -0,0 +1,7 @@ +/*
- (C) Copyright 2016 Beniamino Galvani b.galvani@gmail.com
- SPDX-License-Identifier: GPL-2.0+
- */
+#include <common.h>
And we shouldn't have an empty file here. I see later on in the series we patch this file which means we should probably be squashing some patches together or reworking things a bit. Also, you set CONFIG_DISPLAY_BOARDINFO but never define checkboard to print out the device we're on, which would be a good thing to populate here.