Re: [PATCH] phy: usbphyc: use regulator_set_enable_if_allowed for disabling vdd supply

On 7/3/20 7:13 PM, Patrick Delaunay wrote:

Use regulator_set_enable_if_allowed() api instead of regulator_set_enable() while disabling vdd supply. This way the driver doesn't see an error when disabling an always-on regulator.

This patch is needed since the commit f93fab312615 ("Revert 'power: regulator: Return success on attempt to disable an always-on regulator'") and use the API introduced by commit cc4a224af226 ("power: regulator: Introduce regulator_set_enable_if_allowed api").

Signed-off-by: Patrick Delaunay patrick.delaunay@st.com

drivers/phy/phy-stm32-usbphyc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/phy-stm32-usbphyc.c b/drivers/phy/phy-stm32-usbphyc.c index 464b0735e8..c6d3048602 100644 --- a/drivers/phy/phy-stm32-usbphyc.c +++ b/drivers/phy/phy-stm32-usbphyc.c @@ -263,7 +263,7 @@ static int stm32_usbphyc_phy_power_off(struct phy *phy) return 0;

if (usbphyc_phy->vdd) {

• ret = regulator_set_enable(usbphyc_phy->vdd, false);
  

• ret = regulator_set_enable_if_allowed(usbphyc_phy->vdd, false);
  

  if (ret) return ret; }

Reviewed-by: Patrice Chotard patrice.chotard@st.com

Thanks

Patrice