Re: [U-Boot] [PATCH] make fw_setenv write multiple variables

Dear Marc Leeman,

In message 1f729c480904300627r5661774ej7d2cf5a19bee1083@mail.gmail.com you wrote:

IIRC, I tried to stick as close to the fw_Xenv code structure as possible; as such, this basically copies the fw_setenv block and modifies it without interfering or breaking in the upstream code.

Indeed. That code duplication is another problem, which for itself would be reason enough to reject the patch. It's unmaintainable.

Best regards,

Wolfgang Denk