Re: [U-Boot] [PATCH 1/2] usb: host: xhci: make sure to power up PHY

Hi

On 06/23/2014 04:25 PM, Felipe Balbi wrote:

some boards won't work if the PHY isn't explicitly powered up.

Signed-off-by: Felipe Balbi balbi@ti.com

drivers/usb/host/xhci-omap.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-omap.c b/drivers/usb/host/xhci-omap.c index e667810..912b2bd 100644 --- a/drivers/usb/host/xhci-omap.c +++ b/drivers/usb/host/xhci-omap.c @@ -98,6 +98,7 @@ static int omap_xhci_core_init(struct omap_xhci *omap) { int ret = 0;

• usb_phy_power(1);

Should this not be in the omap_usb_phy.c in the omap_enable_phy call below? I mean you are enabling the PHY right?

omap_enable_phy(omap);

ret = dwc3_core_init(omap->dwc3_reg);