On Friday, June 03, 2011 16:14:29 McClintock Matthew-B29882 wrote:
On Fri, Jun 3, 2011 at 2:16 PM, Mike Frysinger wrote:
On Thu, Jun 2, 2011 at 11:48 PM, Mike Frysinger wrote:
any reason you couldnt add silent=0 to CONFIG_EXTRA_ENV_SETTINGS ?
I was just perturbed that setting CONFIG_SILENT_CONSOLE did not actually make the console silent - I thought it would be cleaner to have a define available for this.
i know people are surprised by this from time to time, but i think the README is pretty clear about it. is there clarification there that you'd like ?
since CONFIG_EXTRA_ENV_SETTINGS is board-specific, i'm not sure adding another board-specific define for a single default env var gains us anything.
Not really too concerned either way here.
Some of our boards have some really long CONFIG_EXTRA_ENV_SETTINGS and it's nice to try to keep that shorter by moving stuff into CONFIG_NFSBOOTCOMMAND, CONFIG_RAMBOOTCOMMAD, CONFIG_SILENT_CONSOLE_AT_BOOT, etc. but beyond that we can just add to our CONFIG_EXTRA_ENV_SETTINGS as well.
we had a similar thing with Blackfin boards, but we just made it our own set of defines that eventually culminated in a single CONFIG_EXTRA_ENV_SETTINGS
*shrug* -mike