
22 Jul
2009
22 Jul
'09
9:02 a.m.
Dear Niklaus Giger,
In message 1248244909-7085-1-git-send-email-niklaus.giger@member.fsf.org you wrote:
Signed-off-by: Niklaus Giger niklaus.giger@member.fsf.org
We tested some boot flashes as possible second source. As some had ids above 0x7f, we had to implement JEDEC JEP106Z in cfi_flash.c.
Please provide at least this statement as part of the commit message.
I now that I just missed the merge window, but the patches are not urgent and I was away for a three week
Stefan is probably willin gto consider this as a bug fix (at least I would not reprimand him if he did :-)
static void cmdset_amd_read_jedec_ids(flash_info_t *info) {
- flash_write_cmd(info, 0, 0, AMD_CMD_RESET);
- ushort bankId = 0;
- uchar manuId;
flash_write_cmd(info, 0, 0, AMD_CMD_RESET);
Please use TAB for indentation.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Use C++ to confuse your enemies; use C to produce stable code.