Re: [U-Boot] [PATCH][v2] arch/powperpc: Fix start_align due to use of __ffs64() instead ffs64()

On 01/22/2016 02:20 AM, Ashish Kumar wrote:

Return value of ffs64() different to that of __ffs64(), ffs64(0x80000000) = 0x20 __ffs64(0x80000000) = 0x1f, as result of this change -1 from start_align needs to be removed. Incorrect DDR law was created in case of B4860qds

Signed-off-by: Ashish Kumar Ashish.Kumar@nxp.com

• Test on B4860qds and T1040
• 83xx platform not tested

Revised commit message as

Incorrect DDR law was created in case of B4860qds after commit 2d2f490d. Return value of ffs64() differs from __ffs64(), eg. ffs64(0x80000000) = 0x20 __ffs64(0x80000000) = 0x1f As a result of this change, callers need to adjust the expected return value by removing -1.

Applied to u-boot-mpc85xx master branch. Awaiting upstream.

Thanks.

York