Hi Jean-Christophe,
On Monday 09 March 2009, Jean-Christophe PLAGNIOL-VILLARD wrote:
On 09:14 Mon 09 Mar , Stefan Roese wrote:
On Monday 09 March 2009, Kyungmin Park wrote:
+++ b/common/Makefile @@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o +COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.o
Shouldn't we change this define (CONFIG_JFFS2_CMDLINE) to something else now, since it's not really JFFS2 specific anymore? I suggest to change it to CONFIG_CMD_MTDPARTS. This seems more logical to me.
What do you think?
It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?
Is it? I have not seen such a patch. Do you have a link? (I added Jean-Christophe to CC).
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=commit;h=9163868e5575d841089a 84d97f287b2ca15486a1
Hmm. Now I'm a little confused. It seems that you added this patch with some changes to the "for-next" branch of your arm git repository. Did you post the changed version of this patch on the list? I couldn't find it.
Don't get me wrong. I appreciate that you did the required change to the patch. But please post the path on the list after you changed it. And also please incorporate the change to the patch description as I suggested. Additionally I think that this patch doesn't really belong into your arm repository.
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================