2012/1/25 Marek Vasut marek.vasut@gmail.com:
From: Marek Vasut marek.vasut@gmail.com
Signed-off-by: Marek Vasut marek.vasut@gmail.com Signed-off-by: Vasily Khoruzhick anarsoul@gmail.com [vasily: adapted Marek's old version for newer u-boot, fixed multiple keypresses handling]
Fine ... albert, can you comment on it?
Vasily, do you think this code is good? I want an honest answer!
Well, it's overcomplicated due to missing _generic_ keyboard support in u-boot.
Then create such code!
It's possible to separate buffer handling, layout management into some "keyboard-core", so keyboard driver provides only key press/release events to core and then core decides what to do if we have multiple keys pressed, if modifier is pressed, etc, etc...
Great idea, let's put this patch on hold and implement the support layer then!
Anyway, for me this code is easy to understand, but it's for now. So if you want _really_ honest answer -- wait for few weeks so I can re-review it with fresh view.
I don't mind. But maybe you can really implement the keyboard support layer and simply add this as a clean and easy driver.
M
Regards Vasily