Dear Mike Frysinger,
In message 1230857672-11798-1-git-send-email-vapier@gentoo.org you wrote:
From: Bryan Wu bryan.wu@analog.com
A couple of buffers in the fat code are declared as an array of bytes. But it is then cast up to a structure with 16bit and 32bit members. Since GCC assumes structure alignment here, we have to force the buffers to be aligned according to the structure usage.
...
+__u8 get_vfatname_block[MAX_CLUSTSIZE] __attribute__ ((aligned(sizeof(__u16))));
...
+__u8 get_dentfromdir_block[MAX_CLUSTSIZE] __attribute__ ((aligned(sizeof(__u32))));
...
+__u8 do_fat_read_block[MAX_CLUSTSIZE] __attribute__ ((aligned(sizeof(__u32))));
What makes you sure that a 16 resp. 32 bit alignment is sufficient, and that gcc does not decide to align such structures even stricter?
Wouldn't it make more sense to use "__alignof__ ()" here to be on the safe side?
Best regards,
Wolfgang Denk