Re: [U-Boot] [PATCH v3 62/62] x86: link: Add a config for 64-bit U-Boot

Hi Simon,

On Mon, Jan 16, 2017 at 10:04 PM, Simon Glass sjg@chromium.org wrote:

Add a new link config which uses 64-bit U-Boot. This is not fully

I guess you want to say: a new "board" config instead of "link" config?

functional but is it a start. Missing features:

• SDRAM sizing
• Booting linux
• EFI support
• SCSI device init

(and others)

Signed-off-by: Simon Glass sjg@chromium.org

Changes in v3:

• Drop patch 'x86: Add basic support for U-Boot as a 64-bit EFI application'
• Drop patch 'Mention the MRC region in the README'
• Drop patch 'x86: link: Add build options for SPL'
• Drop unnecessary defconfig options for chromebook_link64
• Avoid including helloworld.efi in the 64-bit U-Boot

Changes in v2:

• Drop patch 'video: Use ulong for video frame buffer address'
• Add a new 64-bit link config instead of changing the existing one

board/google/Kconfig | 7 +++ board/google/chromebook_link/Kconfig | 2 +- board/google/chromebook_link/MAINTAINERS | 7 +++ configs/chromebook_link64_defconfig | 89 ++++++++++++++++++++++++++++++++ 4 files changed, 104 insertions(+), 1 deletion(-) create mode 100644 configs/chromebook_link64_defconfig

diff --git a/board/google/Kconfig b/board/google/Kconfig index 7ba73a2461d..e56c026ef6d 100644 --- a/board/google/Kconfig +++ b/board/google/Kconfig @@ -22,6 +22,13 @@ config TARGET_CHROMEBOOK_LINK and it provides a 2560x1700 high resolution touch-enabled LCD display.

+config TARGET_CHROMEBOOK_LINK64

•   bool "Chromebook link 64-bit"
  

•   help
  

•     This is the Chromebook Pixel released in 2013. With this config
  

•     U-Boot is built as a 64-bit binary. This allows testing while this
  

•     feature is being completed.
  

config TARGET_CHROMEBOX_PANTHER bool "Chromebox panther (not available)" select n diff --git a/board/google/chromebook_link/Kconfig b/board/google/chromebook_link/Kconfig index 5c57945d77a..8999b582943 100644 --- a/board/google/chromebook_link/Kconfig +++ b/board/google/chromebook_link/Kconfig @@ -1,4 +1,4 @@ -if TARGET_CHROMEBOOK_LINK +if TARGET_CHROMEBOOK_LINK || TARGET_CHROMEBOOK_LINK64

config SYS_BOARD default "chromebook_link" diff --git a/board/google/chromebook_link/MAINTAINERS b/board/google/chromebook_link/MAINTAINERS index bc253a2ba7b..e7aef53390c 100644 --- a/board/google/chromebook_link/MAINTAINERS +++ b/board/google/chromebook_link/MAINTAINERS @@ -4,3 +4,10 @@ S: Maintained F: board/google/chromebook_link/ F: include/configs/chromebook_link.h F: configs/chromebook_link_defconfig

+CHROMEBOOK LINK 64-bit BOARD +M: Simon Glass sjg@chromium.org +S: Maintained +F: board/google/chromebook_link/ +F: include/configs/chromebook_link.h +F: configs/chromebook_link64_defconfig diff --git a/configs/chromebook_link64_defconfig b/configs/chromebook_link64_defconfig new file mode 100644 index 00000000000..dd8175ec767 --- /dev/null +++ b/configs/chromebook_link64_defconfig @@ -0,0 +1,89 @@ +CONFIG_X86=y +CONFIG_SPL_GPIO_SUPPORT=y +CONFIG_SPL_LIBCOMMON_SUPPORT=y +CONFIG_SPL_LIBGENERIC_SUPPORT=y +CONFIG_SYS_MALLOC_F_LEN=0x2000 +CONFIG_SPL_I2C_SUPPORT=y +CONFIG_SPL_SERIAL_SUPPORT=y +CONFIG_SPL_SPI_FLASH_SUPPORT=y +CONFIG_SPL_SPI_SUPPORT=y +CONFIG_X86_RUN_64BIT=y +CONFIG_VENDOR_GOOGLE=y +CONFIG_DEFAULT_DEVICE_TREE="chromebook_link" +CONFIG_TARGET_CHROMEBOOK_LINK=y

I think this should be: CONFIG_TARGET_CHROMEBOOK_LINK64=y

[snip]

I can fix these two when applying if you don't have different thoughts.

Regards, Bin