21 Mar
2020
21 Mar
'20
9:53 a.m.
On Wed, 2020-03-11 at 08:11 +0100, Marek Vasut wrote:
On 3/11/20 7:50 AM, Chunfeng Yun wrote: [...]
- @u3_ctrl_p[x]: ip usb3 port x control register, only low 4bytes are used
- @u2_ctrl_p[x]: ip usb2 port x control register, only low 4bytes are used
- @u2_phy_pll: usb2 phy pll control register
- */
+struct mtk_ippc_regs {
- __le32 ip_pw_ctr0;
- __le32 ip_pw_ctr1;
- __le32 ip_pw_ctr2;
Please define the registers with #define macros , this struct-based approach doesn't scale.
When I prepare for v2, and find that if define registers as macros, it do not keep the same style with the xhci core, so I leave it unchanged in v2, if you still suggest to avoid struct-based approach, I will change it in v3 version, thanks
[..]