
Hi Albert,
On 11/16/2015 05:16 PM, Albert ARIBAUD wrote:
Hello Vignesh,
[...]
Do you see any issues with above change?
(1) So your s_init runs even before board_init_f_mem(), right?
Your working fix seems to imply that as long as s_init() is run after board_init_f_mem (and any time before board_init_f) it will work. If so, then another, fix, preferable to the above, would be that the call to s_init be moved between those to board_init_f_mem and board_init_f. Can you test that?
Yes, gd area gets initialized to 0 in board_init_f_mem(). Initializing the console thereafter fixes the issue. There is nothing between call to board_init_f_mem and board_init_f. board_init_f gets called right after board_init_f_mem (in arch/arm/lib/crt0.S), therefore I thought of moved in serial_init call to board_init_f as above.
Can you please submit a patch? Bugfixes are welcome even when the merge window is closed.
Yeah, I will submit a patch shortly. Thanks!