Re: [U-Boot] [PATCH v5 1/4] arm: dts: socfpga: Add u-boot, dm-pre-reloc for sysmgr and clkmgr nodes

On 11/7/19 3:10 AM, Ley Foon Tan wrote: [...]

diff --git a/arch/arm/dts/socfpga-common-u-boot.dtsi b/arch/arm/dts/socfpga-common-u-boot.dtsi index 322c858c4b..d55460755f 100644 --- a/arch/arm/dts/socfpga-common-u-boot.dtsi +++ b/arch/arm/dts/socfpga-common-u-boot.dtsi @@ -10,6 +10,10 @@ }; };

+&clkmgr {

• u-boot,dm-pre-reloc;

+};

&rst { u-boot,dm-pre-reloc; }; @@ -17,3 +21,7 @@ &sdr { u-boot,dm-pre-reloc; };

+&sysmgr {

• u-boot,dm-pre-reloc;

+};

Gen5 doesn't have any clock driver, so does it really make sense to retain the clkmgr node in SPL now ? Seems like this only grows the SPL size with no benefit.

[...]